This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Paged keys rpc for child storage. #9100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheme
added
A0-please_review
cheme
added
the
D2-notlive 💤
|
thank you! cc @jacogr |
| @@ -34,6 +34,7 @@ pub trait ChildStateApi<Hash> { | |||
| /// RPC Metadata | |||
| type Metadata; | |||
|
|
|||
| /// DEPRECATED: Please use `childstate_getKeysPaged` with proper paging support. | |||
There was a problem hiding this comment.
Do we not actually mark this as deprecated somewhere?
What is the process to eventually get rid of this function?
There was a problem hiding this comment.
I am not really sure. This is just text that will show in rust doc, I copy pasted it from its top storage counterpart.
Maybe there is a better way or could be interesting to remove in a next version with other impacting rpc changes
(I thing the comment for the state function was here for rather long).
jacogr
reviewed
Jun 15, 2021
Co-authored-by: Alexander Popiak <alexander.popiak@gmail.com>
Co-authored-by: Alexander Popiak <alexander.popiak@gmail.com>
arkpar
approved these changes
Jul 4, 2021
shawntabrizi
approved these changes
Jul 7, 2021
|
I like the fact that this PR does not break anything, I think I will open a different one removing the deprecated api. |
|
bot merge |
|
Trying merge. |
ghost
merged commit
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Paged rpc
childstate_getKeysPagedfor child storage on the same model asstate_getKeysPaged.closes #9086.
polkadot companion: paritytech/polkadot#3258